CiviCRM

Build upgrade script from v1.7 -> v1.8

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed/Completed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8
  • Component/s: None
  • Labels:
    None

Description


We only need to do this for mysql41 and higher, so only one file needed. Should be significanly easier with the new FK naming convention

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Swati Vaidya added a comment -
Fixed with r-10041
Show
Swati Vaidya added a comment - Fixed with r-10041
Hide
Permalink
David Greenberg added a comment -
As of r10505 on 1.8 branch, civicrm_upgradedb_v1.7_v1.8_41.mysql has the following problems:

1. Payment processor types need to be INSERTED in civicrm_payment_processor_type table (see lines 4337+ of civicrm_data.mysql).
2. Several new columns have been added to civicrm_payment_processor_type which aren't reflected in the upgrade script:
- url_recur_default
- url_recur_test_default
(may be others - but these are definitely missing)

Please do the following test after fixing the above:
* Load a 1.8 DB using civicrm_41.mysql + civicrm_data.mysql
* Dump the table structure
* Load a 1.7 DB using civicrm_41.mysql + civicrm_data.mysql from 1.7 branch
* Run upgrade script on 1.7 DB and dump it's table structure
* Do a DIFF on two DB structure dumps. They should be the same.
Show
David Greenberg added a comment - As of r10505 on 1.8 branch, civicrm_upgradedb_v1.7_v1.8_41.mysql has the following problems: 1. Payment processor types need to be INSERTED in civicrm_payment_processor_type table (see lines 4337+ of civicrm_data.mysql). 2. Several new columns have been added to civicrm_payment_processor_type which aren't reflected in the upgrade script: - url_recur_default - url_recur_test_default (may be others - but these are definitely missing) Please do the following test after fixing the above: * Load a 1.8 DB using civicrm_41.mysql + civicrm_data.mysql * Dump the table structure * Load a 1.7 DB using civicrm_41.mysql + civicrm_data.mysql from 1.7 branch * Run upgrade script on 1.7 DB and dump it's table structure * Do a DIFF on two DB structure dumps. They should be the same.
Hide
Permalink
Donald A. Lobo added a comment -

also on a clean db, the data dumps should also match or be relatively close. so do ensure that data in the two are "similar"
Show
Donald A. Lobo added a comment - also on a clean db, the data dumps should also match or be relatively close. so do ensure that data in the two are "similar"
Hide
Permalink
Abhilasha Vasu added a comment -
fixed in r10522
let me know if any changes required
Show
Abhilasha Vasu added a comment - fixed in r10522 let me know if any changes required
Hide
Permalink
Donald A. Lobo added a comment -

got a syntax error when sourcing the upgrade file. was an obvious error :( Please do a better job QA'ing the next time you resolve an important issue.


Show
Donald A. Lobo added a comment - got a syntax error when sourcing the upgrade file. was an obvious error :( Please do a better job QA'ing the next time you resolve an important issue.
Hide
Permalink
Donald A. Lobo added a comment -


I did the following and found and fixed a few more things:

1. Created civicrm_41.mysql fro v1.7 and then loaded the sql + data + upgrade file into mysql. I then took a structure dump and a data dump

2. Did the same for 1.8 and loaded sql + data. I then took a structure dump and a data dump

3. did a diff between the two and found a few more issues as follows:

a. activity_tag1_* were in phonecall/meeeting tables and not used. deleted them from 1.8 xml files
b. payment_processor_id was not being added as an FK in the upgrade file
Show
Donald A. Lobo added a comment - I did the following and found and fixed a few more things: 1. Created civicrm_41.mysql fro v1.7 and then loaded the sql + data + upgrade file into mysql. I then took a structure dump and a data dump 2. Did the same for 1.8 and loaded sql + data. I then took a structure dump and a data dump 3. did a diff between the two and found a few more issues as follows: a. activity_tag1_* were in phonecall/meeeting tables and not used. deleted them from 1.8 xml files b. payment_processor_id was not being added as an FK in the upgrade file
Hide
Permalink
Manish Zope added a comment -
Verify for 2.0
Show
Manish Zope added a comment - Verify for 2.0

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.4#664-r167664) | Report a problem
Powered by a free Atlassian JIRA open source license for CiviCRM . Try JIRA - bug tracking software for your team.