|
The above patch does not yes add the personal message into email receipts (either user or admin). When discussed with dgg on IRC, we concluded that this was probably necessary in order to inform users of the messages so that they can review them and take action if they are inappropriate etc.
I'll try and get an updated patch that includes this tomorrow. Actually, the pcp personal message IS already included in the email receipts, so I don't think any further work is required on this patch. At least, no additional functionality is needed - just review and testing. woo hoo!
PAtch updated to also fix CRM_Contribute_BAO_Contribution:getSoftContributionList() to include the full range of pcp properties (pcp_display_in_roll, pcp_roll_nickname and pcp_personal_note) in its return.
Patch updated to work with 3.0-beta4
Just noticed that someone started working on this... I've been using this patch for a good while now, and it works well. One thing I have noticed though is that when you edit a contribution, the option to make a contribution listed anonymously is missing. You can edit the name and message, and remove the contribution form the honor role completely, but you can't make it appear listed as anonymous - which is an option when you make the donation in the first place.
Sunil - I'd like to do a quick QA pass on this as well so assign to me when you're done reviewing it. thx!
Assign to dgg as per comments
Some of the point noticed .. 1. View Contribution -> Personal Campaign Page info Display looks too complex if Note is present (didn't get which one is label / value ) 2. Edit Contribution -> if Show my contribution in the public honor roll checkbox is checked then field label 'Name' and 'Personal Note' are too away from HTML fields 3. i. Do the On line contribution using PCP but don't check the 'honor roll' checkbox ii. Edit the Same contribution record you will find 'honor roll' checkbox is unchecked [OK] iii. Select checkbox, No radio button is auto selected [here 'Include my name and message' radio button should be auto selected (should be same like Online contribution page for PCP )] iv. if You save the form without selected any radio button, form is saved without error but in HONOR ROLL only Amount is showing => if 'honor roll' checkbox is checked then first radio button( Include my name and message ) should be auto selected. Basic functionality working fine.... |
||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
New Feature
Closed
Trivial
Add 'message' field to personal contribution page (pcp) contributions
I have also added the ability to edit the details of a pcp message including the ability to change the nickname, personal note, and weather or not the contribution should show up in the honor roll (anonymous). However, I think there may be some small problems when assigning a contribution to a pcp through the CRM. The pcp and soft credit fields are both visible on the contribution edit form, but if you select a pcp page, soft credit is actually impled by the owner of the pcp page, and so the soft credit dropdown has no effect. Perhaps this needs to be made more clear somehow... suggestions?
I was also unsure of the best place to do some things, soecifically, creating up the soft credit db entry. I chose to do it in CRM/Contribute/BAO/Contribution.php in the end. I did it in a very similar way to how it is done in CRM/Contribute/Form/Contribution/Confirm.php - it seems to me that perhaps the code in Confirm.php would be no longer needed with it done this way?