[#CRM-6774] Changing case type can result in more than one instance of activities specified as max_instances=1 if activity was "with" a contact other than client

CiviCRM

Changing case type can result in more than one instance of activities specified as max_instances=1 if activity was "with" a contact other than client

Created: 01/Sep/10 08:10 PM Updated: 07/Sep/10 02:12 PM

Component/s:

CiviCase

Affects Version/s:

3.2.2

Fix Version/s:

3.2.4

Time Tracking:

Not Specified

Issue Links:

Suplementation

This issue suplements:

~~CRM-6692~~ Changing case type can result in more than one instance of activities specified as max_instances=1

Description

« Hide

This is a followup to ~~CRM-6692~~.

The code in CRM_Case_XMLProcessor::isActivityPresent has a WHERE clause in the select that checks the activity_target is the client.

So it seems that the obvious fix is to remove that check, except I'm hesitant to do that because it must have been there for a reason. I know that case activities always used to be "with" the client before 3.2, but even then there's no reason I can think of to have this check, so maybe it is there for some other reason? Does it have something to do with multiclient functionality?

All

Comments

Work Log

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Kurund Jalmi added a comment - 03/Sep/10 01:41 PM

Removing target clause, can you QA and close the issue

[ Permlink | « Hide ]

Dave D added a comment - 07/Sep/10 02:12 PM

r29587
I also looked through the code and tried to backtrace all the places this could get called. Not foolproof but doesn't seem like this is called during other processes.