Ascending order - Click to sort in descending order
Hide
Permalink
lobo Donald A. Lobo added a comment -

brian:

can u quickly verify and generate a PR (or let me know and i can do the needful)

Show
lobo Donald A. Lobo added a comment - brian: can u quickly verify and generate a PR (or let me know and i can do the needful)
Hide
Permalink
nant Nicholas Antimisiaris added a comment - - edited

Also, since Joomla 3.x has dropped support for the DS separator we can remove the DS in favor of the '/' which is handled just fine now by PHP in all OS.

so define line can be changed to:

if (!defined('CIVICRM_SETTINGS_PATH'))

{ define('CIVICRM_SETTINGS_PATH', JPATH_BASE . '/' . 'components' . '/' . 'com_civicrm' . '/' . 'civicrm.settings.php'); }
Show
nant Nicholas Antimisiaris added a comment - - edited Also, since Joomla 3.x has dropped support for the DS separator we can remove the DS in favor of the '/' which is handled just fine now by PHP in all OS. so define line can be changed to: if (!defined('CIVICRM_SETTINGS_PATH')) { define('CIVICRM_SETTINGS_PATH', JPATH_BASE . '/' . 'components' . '/' . 'com_civicrm' . '/' . 'civicrm.settings.php'); }
Hide
Permalink
lobo Donald A. Lobo added a comment -

how about

define('CIVICRM_SETTINGS_PATH', JPATH_BASE . '/components/com_civicrm/civicrm.settings.php');

Show
lobo Donald A. Lobo added a comment - how about define('CIVICRM_SETTINGS_PATH', JPATH_BASE . '/components/com_civicrm/civicrm.settings.php');
Hide
Permalink
nant Nicholas Antimisiaris added a comment -

works ofc - but when I had my Joomla debug set to maximum Developer mode I did get a notice that CIVICRM_SETTINGS_PATH had already been defined earlier (could not tell where) - that's why I enclosed it in an if statement.

Show
nant Nicholas Antimisiaris added a comment - works ofc - but when I had my Joomla debug set to maximum Developer mode I did get a notice that CIVICRM_SETTINGS_PATH had already been defined earlier (could not tell where) - that's why I enclosed it in an if statement.