Tagset on civicase is broken

@dlobo, This is a weird one, I'm not comiting because I'm not sure why it didn't work.

The problem is that when you delete tags in a tagset (from the edit button in the case), it didn't really delete all of them.

The code deletes all the tags and add the ones that are saved in the dialog. The code that DOESN'T work is on CRM/Core/BAO/EntityTag.php

static function del( &$params )
{
$entityTag = new CRM_Core_BAO_EntityTag( );
$entityTag->copyValues( $params );
if ( $entityTag->find( true ) )

{ $entityTag->delete( ); //invoke post hook on entityTag require_once 'CRM/Utils/Hook.php'; $object = array( 0 => array( 0 => $params['entity_id'] ), 1 => $params['entity_table'] ); CRM_Utils_Hook::post( 'delete', 'EntityTag', $params['tag_id'], $object ); }

}

static function del( &$params )
{
$entityTag = new CRM_Core_BAO_EntityTag( );
$entityTag->copyValues( $params );
if ( $entityTag->delete( ))

{ //invoke post hook on entityTag require_once 'CRM/Utils/Hook.php'; $object = array( 0 => array( 0 => $params['entity_id'] ), 1 => $params['entity_table'] ); CRM_Utils_Hook::post( 'delete', 'EntityTag', $params['tag_id'], $object ); }

;
}

When I was looking at the code, it looked like the delete was transformed into a delete ... where id = xxx instead of where entity_id=yyy & civicrm_table=civicrm_case

Basically, I don't understand, so I don't svn commit, but the second version works, the first doesn't.

X+