Membership Count on Contact Summary is showing all memberships instead of active memberships due to invalid query

A regression bug was introduced in 4.2.0 which inadvertently changed the behavior of the function which gets the membership count for the Memberships tab. The intended behavior is to only show memberships whose status "is current" (i.e. is_current_membership flag is true). This is consistent with the tab count behavior for Groups and Relationships.

NOTE: There's a discussion on the forums as to what the behavior "should be" - and some folks would like to see both current and not current (e.g. expired) memberships counted. One possible solution for the mid-term is to show 2 values in the tab - "current / not current". For example, a contact with a single expired membership would have this on their tab:

0 / 1

A patch which implements this would need to address the same thing for other tabs which have active or current or cancelled vs. inactive / not current records (Contributions, Events, Relationships, Groups)