Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-11010

condition custom replyTo option correction

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.2.2
    • Fix Version/s: 4.2.3
    • Component/s: CiviMail
    • Labels:
      None

      Description

      the custom replyto option for civimail is configured in mailing settings.
      but in our form construction, we only condition the field existence using isset. we should be using isset + !empty. with the current condition, if you change the value on then off, and return to the mailing form, the reply to field persists because the array key still exists in the config object.

      https://fisheye2.atlassian.com/browse/CiviCRM/trunk/CRM/Mailing/Form/Upload.php?hb=true
      line 234. we should have:
      if ( isset($config->replyTo) && !empty($config->replyTo) && ! CRM_Utils_Array::value( 'override_verp', $options ) ) {

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              lcdweb Brian Shaughnessy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: