Details
-
Type: Task
-
Status: Done/Fixed
-
Priority: Major
-
Resolution: Fixed/Completed
-
Affects Version/s: None
-
Fix Version/s: 1.0
-
Component/s: Internationalisation
-
Labels:None
Description
The getQILL methods in CRM/History/Selector.php and CRM/Contact/Selector.php build a ?human? language expansion of the search query. Unfortunately, they contain constructs like
$patternOr = "/(.*) or$/";
[...]
$str = 'Contact Type -';
if ($fv['cb_contact_type']) {
foreach ($fv['cb_contact_type'] as $k => $v) {
$str .= " {$k}s or";
}
$str = preg_replace($patternOr, $replacement, $str);
} else {
$str .= ' All';
}
which can be next to impossible to localise (not to mention pushing regexps to translators is always risky).