4.3.alpha1 breaks payment processors

Additional fixes needed subsequent to changing civicrm_payment_processor.payment_processor_type to payment_processor_type_id

1. Fix old column name reference in CRM_Core_Payment::handlePaymentMethod (line 214) - done, DGG

2. Replace hard-coded references to payment_processor_type_id in PayPalImpl.php (fetch ID via name column):

CRM/Core/Payment/PayPalImpl.php: if ($this->_paymentProcessor['payment_processor_type_id'] == '1') {
CRM/Core/Payment/PayPalImpl.php: elseif ($this->_paymentProcessor['payment_processor_type_id'] == '3') {
CRM/Core/Payment/PayPalImpl.php: if ($this->_paymentProcessor['payment_processor_type_id'] == '1' ||
CRM/Core/Payment/PayPalImpl.php: $this->_paymentProcessor['payment_processor_type_id'] == '2'
CRM/Core/Payment/PayPalImpl.php: if ($this->_paymentProcessor['payment_processor_type_id'] != '1') {

3. Move CRM/Core/BAO/PaymentProcessor.php to Financial directory since it's DAO is there and PaymentProcessorType.php is also there.

Please test a 3rd party processor extension install and uninstall. Then assign to Chris Burgess for QA to test with his payment processor extension.

– Original Post ----- (We believe that extension manager issues noted below have been fixed via Tim Otten's commits against this issue) --------

Enabling some payment processors causes CiviCRM to die with SQL error as it tries to reference the renamed column civicrm_payment_processor.payment_processor_type

A quick grep shows the following files may still refer to this column. The column was apparently renamed during the civiaccount branch.

CRM/Financial/BAO/PaymentProcessorType.php
CRM/Extension/Manager/Payment.php
CRM/Core/Payment.php
CRM/Core/Extensions/Extension.php