Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-11954

CRM_Contact_BAO_GroupContact::removeContactsFromGroup() wrong $op with 'Deleted'

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.2.7
    • Fix Version/s: 4.3.0
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      CRM_Contact_Page_View_GroupContact::del() calls CRM_Contact_BAO_GroupContact::removeContactsFromGroup() with $status == 'Deleted' when permanently removing a contact from a group.

      In this case CRM_Contact_BAO_GroupContact::removeContactsFromGroup() assigns the local variable $op = 'edit', but I think the value should be 'delete'. The $op variable is later passed onto a hook invocation at the end of the function. The value of $op is important to hook implementers because the value of $op is the only way to tell what kind of operation is being performed.

      Patch attached.

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              keith@wellebee.com Keith Morgan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: