Scheduled Reminders must exclude deceased contacts, memberships w/ cancelled pending or deceased status and admin override memberships

1. Scheduled reminders for all entity types (activities, participants, memberships) must exclude contacts with is_deceased = 1. Currently there is no filter on this in CRM_Core_BAO_ActionSchedule::buildRecipientContacts This part of the where[] clause should probably be defined above the conditionals on mapping->entity (applies to all)

2. In reviewing CRM_Core_BAO_ActionSchedule::buildRecipientContacts it looks like we are NOT excluding contacts with is_deleted = 1 if mapping->entity is civicrm_participant. Seems like this part of the where[] clause should also be defined above the conditionals on mapping->entity (applies to all)

3. If mapping->entity = civicrm_membership - add filters on where[] to exclude the following:

• membership status in (Pending, Deceased, Cancelled)
• membership.is_override = 1

4. Review existing unit test and extend to test these exclusions.

— Original post —
Greetings,

We ran the scheduler and it sent renewal emails to Members who had a cancelled membership and a current membership. We're using Cancelled memberships to store what memberships people used to have in the past, don't want them to get reminders.

Thanks for helping.

http://forum.civicrm.org/index.php?topic=27709.msg118285#msg118285