Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-12559

Handle failed contributions in CRM_Contribute_BAO_Contribution_Confirm::processContribution()

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.3.1
          • Fix Version/s: 4.3.4
          • Component/s: CiviContribute
          • Labels:
            None

            Description

            We shouldn't really get to https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/Form/Contribution/Confirm.php#L1412 if the contribution has thrown an error. Testing with Authorize.net, was seeing contribs fail due to dupe trxn_id (test00000001).

            Because $contribution was set, CiviCRM tried to do further tasks like record activities, which mean that the user gets a cryptic "Not enough data to record activity," message over in CRM/Activity/BAO/Activity.php instead.

            We should probably bail out at https://github.com/civicrm/civicrm-core/blob/4.3/CRM/Contribute/Form/Contribution/Confirm.php#L1307?

              Attachments

                Activity

                  People

                  • Assignee:
                    lobo Donald A. Lobo
                    Reporter:
                    xurizaemon Chris Burgess
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: