Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-13337

Advanced search: improve form validation

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.4.0
    • Fix Version/s: 4.4.0
    • Component/s: Core CiviCRM, NYSS
    • Labels:
      None
    • Funding Source:
      Core Team Contract

      Description

      http://dev.nysenate.gov/issues/7047

      the advanced search doesn't handle any form validation at the initial form submission level. it's all done much later in the process when the query is being built and its run through data type functions like CRM_Utils_Type::escape().

      that results in fatal errors for something as simple as placing a space in an INT type field. for example – place a space or alpha in the contact ID field.

      We should at least implement some form validation for INT fields and other numeric fields – including custom data fields – and return the user to the form rather than throw fatals.

        Attachments

          Activity

            People

            • Assignee:
              lcdweb Brian Shaughnessy
              Reporter:
              kurund Kurund Jalmi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m