Protection against multiple submits on contributions page doesn't work when confirmation page is turned off

There is multi-click protection on the confirmation page - but not on the prior page if the confirm page is off.

Coleman - I think the main point is to prevent multiple clicks IF the confirmation step is turned off. We can conditionally add the existing submitOnce() onClick attribute to the submit button on Main.php IF civicirm_contribution_page.is_confirm_enabled is false. This is similar to what we currently do in /Event/Form/Registration/Register.php:512 when isMonetary is false (since in that case we skip the confirm step automatically).

Alternatively, we could always use submitOnce() - and pass a different button label string based on whether confirm_enabled is true or false ("Please Wait" vs. "Processing").

I'm assuming this is a small enough fix to be safe for 4.4. If you don't think so, let's chat.

======= Original Post ===========

After having many reports of people double-submitting credit cards I think I managed to replicate it on demo - but the timing is important & I couldn't re-replicate. However, I could reliably replicate that too many clicks results in the following error - which incorrectly implies that the payment wasn't processed - resulting in people doing a second payment

"Sorry but we are not able to provide this at the moment.
An error occurred during form submission. This page requires form data to be submitted for processing and no form data was submitted or processed. We are sorry for any inconvience. Please click here to visit the contribution page and re-start the contribution process.

Return to home page."