Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-13432

Creating membership type with period fixed and start date/rolling date gives warning.

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.5
    • Fix Version/s: 4.4.0
    • Component/s: CiviMember
    • Labels:
      None

      Description

      When trying to add new MembershipType with period type fixed, period start day and period rolling day with month upto september give notice.
      Notice: Undefined index: in CRM_Member_BAO_MembershipType::convertDayFormat() (line 227 of /sites/all/modules/civicrm/CRM/Member/BAO/MembershipType.php).

      and warning when editing membership

      Warning: mktime() expects parameter 4 to be long, string given in CRM_Member_BAO_MembershipType::getDatesForMembershipType() (line 343 of /sites/all/modules/civicrm/CRM/Member/BAO/MembershipType.php).

      The reason being, at line no 406 in https://github.com/civicrm/civicrm-core/blob/master/CRM/Member/Form/MembershipType.php#L406.
      It check for month and day less than 9 which should be 10.
      Attached is the patch against master to fix the same.

        Attachments

          Activity

            People

            • Assignee:
              dgg David Greenberg
              Reporter:
              sushant Sushant Paste
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: