CRM-13726 Only show 'billing addres is same as above' checkbox if there is an address above

          Details

          • Type: Improvement
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.4.1
          • Fix Version/s: 4.4.7
          • Component/s: None
          • Labels:
            None

            Description

            Currently you get the 'billing address is same as above 'checkbox if any address profile appears on the screen. However, if only really makes sense to show it if the profile above presents address fields. Otherwise it makes more sense to suppress the box (the form flow of 'billing address is same as below seems wrong )- it would seem incumbant on form builders to put address fields in the top billing box if they want form fillers to be able to fill from above.

            I can see a shaky argument for filling from below on a form where users were always logged in so below was always prefilling but on balance I think showing the checkbox only for 'above' forms makes sense.

            I guess this could also affect people who have re-organised their tpl to put both profiles above the billing block. Not sure if it makes sense to take that possibility into account

              Attachments

                Issue Links

                is supplemented by

                Improvement - An improvement or enhancement to an existing feature or task. CRM-14073 Provide convenience of using profile address as billing address regardless of profile's placement on the contribution and / or event registration forms

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • Done/Fixed

                  Activity

                  [CRM-13726] Only show 'billing addres is same as above' checkbox if there is an address above
                  Eileen McNaughton added a comment -

                  have done a pr for this

                  Kurund Jalmi added a comment - - edited

                  Eileen,

                  I have applied this patch: https://github.com/civicrm/civicrm-core/pull/1934 to local 4.4 branch

                  • added "Name and Address" profile to "Help Support CiviCRM!" contribution page at the bottom and it still shows checkbox

                  Also for online event registration, checkbox is never shown

                  Kurund Jalmi added a comment -

                  Since this is more of a improvement, I have moved this to 4.5

                  Eileen McNaughton added a comment -

                  Ah I made a mistake on the event one - I think I made a change to the contribution & didn't apply it to event - anyway this is the fix for it

                  https://github.com/eileenmcnaughton/civicrm-core/commit/c1622a21afb8fa86f92be8dc90879ad5aed7e3f5

                  (added to the PR)

                  David Greenberg added a comment -

                  Proposed alternate approach which provides the convenience of a single address block regardless of whether the admin configured profile is above OR below the billing block:

                  1. Show checkbox regardless of whether profile is top or bottom.
                  2. Change checkbox text to "Use a different address for billing". Default state is unchecked (Billing Address is hidden)
                  3. Checking that box unhides the Billing Address block.

                  David Greenberg added a comment -

                  Commited https://github.com/civicrm/civicrm-core/pull/2329 which includes the original PR and the additional change to Register.php at https://github.com/eileenmcnaughton/civicrm-core/commit/c1622a21afb8fa86f92be8dc90879ad5aed7e3f5 (which was not reflected in the original PR as far as I could tell).

                    People

                    • Assignee:
                      David Greenberg
                      Reporter:
                      Eileen McNaughton

                      Dates

                      • Created:
                        Updated:
                        Resolved: