Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Critical
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.4.3
-
Fix Version/s: 4.4.4
-
Component/s: Core CiviCRM
-
Labels:None
Description
to reproduce:
1) create individual: "Active Export"
2) create individual: "Trashed Export"
3) trash the second contact
4) conduct a basic search for the search string "export". this will return 1 result (the first contact)
5) from the search results, select all and export.
the resulting csv file will have both contacts.
from what I gather, when we export the contacts the query is re-run, but the assumed is_deleted = 0 is not included. so any trashed contacts that meet the original search criteria are included.
I tested a few previous versions, and this bug was introduced in 4.4.x.
I traced it to this commit:
https://github.com/civicrm/civicrm-core/commit/34b773b78eb4f1c025fd4865902788ea6c6173fe#diff-2e1de3666cf0b15e640b507b1ab5941f
if we revert the change in line 542 in that commit, the issue is resolved.
however, I'm not sure if there are unintended consequences caused by reverting that. I haven't run across any in testing, but would like others to take a look.
