CRM-14097 Scheduled reminders UI problems

Tim - pretty sure you're planning on cleaning up the UI issues Coleman listed above as part of the Sched Reminder refactoring you're doing for 4.7.

Eileen asked if I wanted to comment on this, so I will.

I think the UI does need cleaning up, but this screen needs to looked at once an SMS provider is set up, so that the full UI is shown. My thoughts are:

• "Send email or SMS" should be renamed to "Is this scheduled reminder active?" to fit in with "Is this event active?" etc. and the scheduled reminders summary screen.
• Email or SMS fields should not be hidden if "Is this scheduled reminder active?" is unticked just as fields aren't hidden if "Is this event active?" is unticked.
• If "Send as Email" is chosen then the SMS Screen should be hidden. If "Send as SMS" is chosen then the Email Screen should be hidden
• I don't like the "Screen" part of SMS Screen and Email Screen. Perhaps Email Details and SMS Details or Email Content *and *SMS Content (although "SMS Provider" is not content.) ?
• "Record activity for automated email or SMS" should be relocated to above "Is this scheduled reminder active?
• The "When... [datepicker] OR [x][hours][before][thing]" section should be hidden it a specific date for sending is selected.
• Are the From Name and/or the From Email only applicable when sending emails? I have never sent an SMS via CiviCRM , so I don't know. If so, I think those fields should be relocated to the Email Details area
• The Group field is pre-filled with the alphabetically first group. IMO it would be better if it showed - select -

BTW, When looking at dmaster site I noticed some regressions from d4.6

The boxes for scheduling repeat reminders are present when you first come to the New Scheduled Reminders form even though the Repeat box is unticked.

Changing the entity away from Activity does not change "Activity Date time" to the appropriate options for the selected entity.

This is probably because ( I gather) Tim is working on the code, but thought I would mention it anyway,

i have issues a PR for some of UI problems.

Change the label of is_active field. Added new field for "Send Email"
Hide Email fields if "Send Email" is unchecked
Added required field validation for email subject
Moved "Record activity for automated email" to email section

PR -> https://github.com/civicrm/civicrm-core/pull/7877

I sent a pull request to civicrm-core adding a validation to email subject and html message in case that "Send mail" checkbox is checked
https://github.com/civicrm/civicrm-core/pull/7924

I have created a pull request for 3 points.

• When saving a new reminder it becomes disabled if you un-check the "send email" box. Inspecting the element, that checkbox is actually the "is_active" field. This is confusing tho because it has a different label on the view screen.
• When un-checking the "send email" box, the email fields do not get hidden
• Email fields do not get validated. Should it really be ok to send a reminder email with a blank subject and blank body?

https://github.com/civicrm/civicrm-core/pull/7928

checked with PR https://github.com/civicrm/civicrm-core/pull/7924 for validation of email subject and email html message.

I'm closing this as it looks like it was fixed in March - please re-open if I am wrong on that

I'm closing this PR as I believe it was replaced looking at the ticket https://github.com/civicrm/civicrm-core/pull/7877 - please re-open the PR if I am wrong