Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-14106

Replace CRM_Utils_Array::value() with !empty() for performance

          Details

          • Type: Improvement
          • Status: Done/Fixed
          • Priority: Minor
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.4.0
          • Fix Version/s: 4.5
          • Component/s: None
          • Labels:

            Description

            When the return value is immediately cast to boolean (e.g in an if() statement) it is pointless to use CRM_Utils_Array::value(). According to my benchmarking, using empty() is 10 times faster.
            Using empty() is also more concise and readable.
            Benchmark test attached.

              Attachments

                Issue Links

                is supplemented by

                Improvement - An improvement or enhancement to an existing feature or task. CRM-13288 CRM_Utils_Array::value(): Not outsmarting PHP + Optimization

                • Trivial - Cosmetic problem like misspelt words or misaligned text.
                • Done/Fixed
                links to

                Web Link PR: civicrm-core#7537: CRM-14106 - Swap CRM_Utils_Array::value for empty() when cast to boolean

                  Activity

                    People

                    • Assignee:
                      colemanw Coleman Watts
                      Reporter:
                      colemanw Coleman Watts
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: