Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-14221

DPS/Payment Express Utilities should be static functions

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.4.4
    • Fix Version/s: 4.5
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      My logs are full of the following

      [code][13-Feb-2014 19:59:21 UTC] PHP Strict Standards: Non-static method CRM_Core_Payment_PaymentExpressUtils::_xmlElement() should not be called statically in /sites/all/modules/civicrm/CRM/Core/Payment/PaymentExpressIPN.php on line 303 [/code]

      This is due to the CRM_Core_Payment_PaymentExpressUtils class functions all being called statically, but not defined as such.

      I have attached a patch to fix this - with the Utils functions now all defined as static - and proper (2 space) indentation applied. Hopefully this matches the style guide!

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              mattrenner Matt Renner
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: