Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-14639

Grant status inconsistent after 4.3 upgrade

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.5
    • Component/s: None
    • Labels:
      None

      Description

      Up to 4.2.x, the grant statuses in civicrm_data.mysql were defined:
      (@option_group_id_grantSt, 'Pending', 1, 'Pending', NULL, 0, 1, 1, NULL, 0, 0, 1, NULL, NULL),
      (@option_group_id_grantSt, 'Granted', 2, 'Granted', NULL, 0, NULL, 2, NULL, 0, 0, 1, NULL, NULL),
      (@option_group_id_grantSt, 'Rejected', 3, 'Rejected', NULL, 0, NULL, 3, NULL, 0, 0, 1, NULL, NULL),
      In 4.3 and 4.4, the grant statuses in civicrm_data.mysql were defined:
      (@option_group_id_grantSt, 'Submitted', 1, 'Submitted', NULL, 0, 1, 1, NULL, 0, 0, 1, NULL, NULL),
      (@option_group_id_grantSt, 'Approved', 2, 'Approved', NULL, 0, NULL, 2, NULL, 0, 0, 1, NULL, NULL),
      (@option_group_id_grantSt, 'Rejected', 3, 'Rejected', NULL, 0, NULL, 3, NULL, 0, 0, 1, NULL, NULL),
      (@option_group_id_grantSt, 'Paid', 4, 'Paid', NULL, 0, NULL, 4, NULL, 0, 0, 1, NULL, NULL),
      (@option_group_id_grantSt, 'Awaiting Information\'', 5, 'Awaiting Information', NULL, 0, NULL, 5, NULL, 0, 0, 1, NULL, NULL),

      This was an oversight due to a missed reversion, iirc, when removing grant applications support from core.

      The names for statuses <=4.2.x map to the statuses for 4.3 and 4.4 as follows:
      Granted -> Paid
      Rejected -> Rejected
      Pending -> Submitted

      A subsequent feature request that JMA implemented was to soften the language of 'Rejected' to 'Ineligible', which led to renaming 'Approved' to 'Eligible'.

      Pradeep, could you add a localized version of the following (after testing it) to the upgrade script in the PR to correct the typo that puts a ' at the end of Awaiting Information in the 4.3 and 4.4 tarballs:
      UPDATE civicrm_option_value v inner join civicrm_option_group g on v.option_group_id=g.id AND g.name='grant_status' SET label='Awaiting Information' WHERE v.label='Awaiting Information\'' and v.name='Awaiting Information';

        Attachments

          Activity

            People

            • Assignee:
              dgg David Greenberg
              Reporter:
              pradeep.nayak Pradeep Nayak
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: