Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-14646

new image display upgrade code not optimized, can result in error

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.4.6
          • Fix Version/s: 4.4.6
          • Component/s: Core CiviCRM
          • Labels:
            None

            Description

            The new code to display contact images without direct web access to the directory (CRM-14499) is a great addition.

            However, I've found some bugs in the upgrade code and have some suggestions for improvements:

            • It should only add the new index once (rather than on each batch call)
            • It should only examine contact records in which the image url is not null
            • It should not use the base url (this one maybe controversial - I'm not sure why we use the baseurl - it means moving the database to a new domain is quite unwieldy.

              Attachments

                Issue Links

                is supplemented by

                Bug - A problem which impairs or prevents the functions of the product. CRM-20326 Contact images url storage in the database

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • Open

                  Activity

                    People

                    • Assignee:
                      timotten Tim Otten
                      Reporter:
                      jamie Jamie McClelland
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      3 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: