Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-14928

Refactor: Unused parameter in Incoming.php/parseAddress

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: 4.5
    • Fix Version/s: Unscheduled
    • Component/s: Core CiviCRM
    • Labels:
      None
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)

      Description

      parseMailingObject passes the variable $field as a pass by ref, but this is never looked at or set by the parseAddress function. $field is then set in a foreach loop later, which is ambiguous.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              johnff John Kirk
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: