Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-14965

Fix Search Builder notice : Notice: Only variable references should be returned by reference in CRM_Contact_Form_Search_Builder->convertFormValues()

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.5
    • Fix Version/s: 4.5
    • Component/s: CiviCRM Search
    • Labels:
      None

      Description

      Any search in Search Builder is now returning this notice:

      Notice: Only variable references should be returned by reference in CRM_Contact_Form_Search_Builder->convertFormValues() (line 311 of /Users/dgg/git/crm_v4.5/CRM/Contact/Form/Search/Builder.php).

      The referenced line has not changed since 4.4 so I'm not sure why the notice is happening in 4.5 (I verified it doesn't happen in 4.4) ???

      Removing the leading & in function name eliminates the notice, but not sure this is the right fix ??
      public function convertFormValues(&$formValues) {

        Attachments

          Activity

            People

            • Assignee:
              monish.deb Monish Deb
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: