civicrm_data.tpl: batch types, status, etc option values were mistakenly put in {ts}

In the file xml/templates/civicrm_data.tpl, the option values have a column 'title', which must be in

{ts}

, and a colum 'name', which must not.

PhilippeS from the forums has discovered a few option value names that were translated, and this causes the "contribution detail" report to fail in non-English.

Faulty code:

– default conference slots
(@option_group_id_conference_slot, '

{ts escape="sql"}Morning Sessions{/ts}', 1, '{ts escape="sql"}

Morning Sessions

{/ts}', NULL, 0, NULL, 1, NULL, 0, 0, 1, NULL, NULL),
(@option_group_id_conference_slot, '{ts escape="sql"}Evening Sessions{/ts}

', 2, '

{ts escape="sql"}Evening Sessions{/ts}', NULL, 0, NULL, 2, NULL, 0, 0, 1, NULL, NULL),

– default batch type
(@option_group_id_batch_type, '{ts escape="sql"}

Contribution

{/ts}', 1, '{ts escape="sql"}Contribution{/ts}

', NULL, 0, NULL, 1, NULL, 0, 0, 1, NULL, NULL),
(@option_group_id_batch_type, '

{ts escape="sql"}Membership{/ts}', 2, '{ts escape="sql"}

Membership

{/ts}', NULL, 0, NULL, 2, NULL, 0, 0, 1, NULL, NULL),

– default batch statues
(@option_group_id_batch_status, '{ts escape="sql"}Open{/ts}

', 1, '

{ts escape="sql"}Open{/ts}', NULL, 0, NULL, 1, NULL, 0, 0, 1, NULL, NULL),
(@option_group_id_batch_status, '{ts escape="sql"}

Closed

{/ts}', 2, '{ts escape="sql"}Closed{/ts}

', NULL, 0, NULL, 2, NULL, 0, 0, 1, NULL, NULL),
(@option_group_id_batch_status, '

{ts escape="sql"}Data Entry{/ts}', 3, '{ts escape="sql"}

Data Entry

{/ts}', NULL, 0, NULL, 3, NULL, 0, 0, 1, NULL, NULL),
(@option_group_id_batch_status, '{ts escape="sql"}Reopened{/ts}

', 4, '

{ts escape="sql"}Reopened{/ts}', NULL, 0, NULL, 4, NULL, 0, 0, 1, NULL, NULL),
(@option_group_id_batch_status, '{ts escape="sql"}

Exported

{/ts}', 5, '{ts escape="sql"}Exported{/ts}

', NULL, 0, NULL, 5, NULL, 0, 0, 1, NULL, NULL),

It will also be necessary to provide an upgrade function to fix the existing values.

In the very short term, I would like to PR against 4.4 to fix the .tpl/sql files. This is a big issue for non-English users who install directly into non-English. I suspect it has not been discovered earlier because not all language are 100% translated.

Forum reference:
http://forum.civicrm.org/index.php/topic,33770.0.html