Details
-
Type:
Sub-task
-
Status: Done/Fixed
-
Priority:
Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.5
-
Fix Version/s: 4.6
-
Component/s: None
-
Labels:None
-
Documentation Required?:None
Description
CRM_Event_Form_ManageEvent_ScheduleReminders was copy-pasted from CRM_Admin_Form_ScheduleReminders and contains only minor tweaks for the context of an event.
Large chunks of copy-pasted code are extremely difficult to maintain, as evidenced by 2 recent improvements to CRM_Admin_Form_ScheduleReminders (CRM-11518 and CRM-13912) which did not make it into the clone.
In addition to removing this file, we should communicate to developers that copy-pasting is not an acceptable way of customizing forms.
Attachments
Issue Links
- blocks
-
CRM-13912 Add SMS support to scheduled reminders
-
- Done/Fixed
-