Details

    • Type: Sub-task
    • Status: To Backport
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.6
    • Fix Version/s: 4.6
    • Component/s: CiviEvent, Core CiviCRM
    • Labels:
      None
    • Documentation Required?:
      None

      Description

      Most Important:

      • ConfirmRepeatMode.tpl has js that relies on the translated label of submit buttons - this will break on non-english sites.
      • ConfirmRepeatMode.tpl contains several untranslated strings in both markup and js.
      • Several of the new files use nonstandard line-breaks (we really ought to teach our CI code checker to catch these).
      • Some js uses deprecated cj instead of CRM.$
      • RecurringEntity.tpl contains unmatched opening/closing <tr> tags.

      Lower Priority:

      • Direct calls to jQuery.dialog - are these necessary? We have a lot of helper functions like CRM.confirm and CRM.loadForm that wrap jQuery dialog and are usually better than calling it directly.
      • Help icons should go after form labels, not the form elements. (we are not 100% consistent about this on all forms in core but I've been cleaning it up).

        Attachments

          Activity

            People

            • Assignee:
              deepak Deepak Srivastava
              Reporter:
              colemanw Coleman Watts
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: