Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-16089

Refactor Form AddSelect CRM_Utils_Api::getEntityName($this)

    Details

    • Type: Task
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.5.8
    • Fix Version/s: 4.7
    • Component/s: None
    • Labels:
      None
    • Documentation Required?:
      Developer Doc

      Description

      We should try to remove this piece of magic from the addSelect method.
      See http://forum.civicrm.org/index.php/topic,35984.0.html for some discussions. I'll add a PR, to try to get a first step in this direction. This would do something like this:

      1) Adds an uninitialized class variable to CRM_Core_Form
      2) Initialized the variable in the event form
      3) Modifies addSelect method to check that variable before doing any of its voodoo.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              mallezie Tim Mallezie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: