Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-16178

Convert all contact forms to use AddField

    Details

    • Type: Epic
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: 4.5.8
    • Fix Version/s: Unscheduled
    • Component/s: None
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      Developer Doc

      Description

      In https://issues.civicrm.org/jira/browse/CRM-16130 we added an addField method, and converted the individual form to use it, this issue is to convert the other Contact Forms.

      I created a list of 'forms' which needs conversion, and which doesn't. I'll use this to track progress.

      Conversions needed:

      Inside CRM_Contact_Form_Edit/

      CRM_Contact_Form_Edit_Website (https://github.com/civicrm/civicrm-core/pull/5883)

      Inside CRM_Contact_Form_Search/

      CRM_Contact_Form_Search_Basic
      CRM_Contact_Form_Search_Criteria

      Inside CRM_Contact_Form_Search_Custom/

      CRM_Contact_Form_Search_Custom_ActivitySearch
      CRM_Contact_Form_Search_Custom_Basic
      CRM_Contact_Form_Search_Custom_ContribSUBNT
      CRM_Contact_Form_Search_Custom_ContributionAggregate
      CRM_Contact_Form_Search_Custom_DateAdded
      CRM_Contact_Form_Search_Custom_EventAggregate
      CRM_Contact_Form_Search_Custom_FullText
      CRM_Contact_Form_Search_Custom_Group
      CRM_Contact_Form_Search_Custom_MultipleValues
      CRM_Contact_Form_Search_Custom_PostalMailing
      CRM_Contact_Form_Search_Custom_PriceSet
      CRM_Contact_Form_Search_Custom_Proximity
      CRM_Contact_Form_Search_Custom_RandomSegment
      CRM_Contact_Form_Search_Custom_Sample
      CRM_Contact_Form_Search_Custom_TagContributions
      CRM_Contact_Form_Search_Custom_ZipCodeRange

      Inside CRM_Contact_Form_Task/

      CRM_Contact_Form_Task_AddToGroup
      CRM_Contact_Form_Task_AddToHousehold
      CRM_Contact_Form_Task_AddToOrganization
      CRM_Contact_Form_Task_AddToTag
      CRM_Contact_Form_Task_AlterPreferences
      CRM_Contact_Form_Task_EmailCommon
      CRM_Contact_Form_Task_Label
      CRM_Contact_Form_Task_PDFLetterCommon
      CRM_Contact_Form_Task_PickProfile
      CRM_Contact_Form_Task_ProximityCommon
      CRM_Contact_Form_Task_RemoveFromGroup
      CRM_Contact_Form_Task_RemoveFromTag
      CRM_Contact_Form_Task_SMSCommon
      CRM_Contact_Form_Task_SaveSearch
      CRM_Contact_Form_Task_Useradd

      No conversions needed:

      CRM_Contact_Form_CustomData: Only addButtons
      CRM_Contact_Form_DedupeFind
      CRM_Contact_Form_Inline: Only addButtons
      CRM_Contact_Form_Location: Nothing to do
      CRM_Contact_Form_Merge: Only addButtons
      CRM_Contact_Form_ProfileContact: No defined entity
      CRM_Contact_Form_RelatedContact: Only addButtons
      CRM_Contact_Form_Task: Only addButtons in wrapper addDefaultButtons
      CRM_Contact_Form_Search: no fields here
      CRM_Contact_Form_Edit_CustomData
      CRM_Contact_Form_Edit_OpenID (no api entity)
      CRM_Contact_Form_Edit_TagsAndGroups (not sure how to do this with the two entitys)
      CRM_Contact_Form_Inline_Address
      CRM_Contact_Form_Inline_CommunicationPreferences
      CRM_Contact_Form_Inline_ContactInfo
      CRM_Contact_Form_Inline_ContactName
      CRM_Contact_Form_Inline_CustomData
      CRM_Contact_Form_Inline_Demographics
      CRM_Contact_Form_Inline_Email
      CRM_Contact_Form_Inline_IM
      CRM_Contact_Form_Inline_Lock
      CRM_Contact_Form_Inline_OpenID
      CRM_Contact_Form_Inline_Phone
      CRM_Contact_Form_Inline_Website
      CRM_Contact_Form_Search_Advanced
      CRM_Contact_Form_Search_Builder
      CRM_Contact_Form_Search_Custom
      CRM_Contact_Form_Search_Interface
      CRM_Contact_Form_Search_Custom_Base
      CRM_Contact_Form_Search_Custom_FullText_AbstractPartialQuery
      CRM_Contact_Form_Search_Custom_FullText_Activity
      CRM_Contact_Form_Search_Custom_FullText_Case
      CRM_Contact_Form_Search_Custom_FullText_Contact
      CRM_Contact_Form_Search_Custom_FullText_Contribution
      CRM_Contact_Form_Search_Custom_FullText_Membership
      CRM_Contact_Form_Search_Custom_FullText_Participant
      CRM_Contact_Form_Task_Batch
      CRM_Contact_Form_Task_Delete
      CRM_Contact_Form_Task_Email
      CRM_Contact_Form_Task_HookSample
      CRM_Contact_Form_Task_LabelCommon
      CRM_Contact_Form_Task_Map
      CRM_Contact_Form_Task_Map_Event
      CRM_Contact_Form_Task_Merge
      CRM_Contact_Form_Task_PDF
      CRM_Contact_Form_Task_Print
      CRM_Contact_Form_Task_Result
      CRM_Contact_Form_Task_SMS
      CRM_Contact_Form_Task_Unhold
      CRM_Contact_Form_Task_SaveSearch_Update

      Followups needed for other classes used here:

      CRM_Custom_Form_CustomData::buildQuickForm()
      CRM_Contact_BAO_Contact_Utils::buildOnBehalfForm()
      CRM_Core_BAO_UFGroup::buildProfile()
      CRM_Core_Form_Tag::buildQuickForm()
      CRM_Group_Form_Edit::buildParentGroups();

      Conversions done:
      CRM_Contact_Form_Contact: Done and merged in https://github.com/civicrm/civicrm-core/pull/5513
      CRM_Contact_Form_Edit_Individual: Done and merged in https://github.com/civicrm/civicrm-core/pull/5456
      CRM_Contact_Form_Edit_Lock: Done and merged in https://github.com/civicrm/civicrm-core/pull/5501
      CRM_Contact_Form_DedupeRules (https://github.com/civicrm/civicrm-core/pull/5649)
      CRM_Contact_Form_Edit_Notes (https://github.com/civicrm/civicrm-core/pull/5512)
      CRM_Contact_Form_Domain (https://github.com/civicrm/civicrm-core/pull/5730)
      CRM_Contact_Form_GroupContact (https://github.com/civicrm/civicrm-core/pull/5731)
      CRM_Contact_Form_Relationship (https://github.com/civicrm/civicrm-core/pull/5745)
      CRM_Contact_Form_Edit_Address (https://github.com/civicrm/civicrm-core/pull/5800)
      CRM_Contact_Form_Edit_CommunicationPreferences (https://github.com/civicrm/civicrm-core/pull/5818)
      CRM_Contact_Form_Edit_Demographics (https://github.com/civicrm/civicrm-core/pull/5845)
      CRM_Contact_Form_Edit_Email https://github.com/civicrm/civicrm-core/pull/5848)
      CRM_Contact_Form_Edit_Household (https://github.com/civicrm/civicrm-core/pull/5849)
      CRM_Contact_Form_Edit_IM (https://github.com/civicrm/civicrm-core/pull/5850)
      CRM_Contact_Form_Edit_Organization (https://github.com/civicrm/civicrm-core/pull/5851)
      CRM_Contact_Form_Edit_Phone (https://github.com/civicrm/civicrm-core/pull/5866)

        Attachments

          Activity

            People

            • Assignee:
              mallezie Tim Mallezie
              Reporter:
              mallezie Tim Mallezie
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: