Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.6.2
-
Fix Version/s: 4.6.4
-
Component/s: None
-
Labels:
-
Documentation Required?:None
-
Funding Source:Core Team Funds
Description
I wanted to open a ticket to track this since I'm unclear as to whether we are about to introduce a bug into 4.6.3
This commit
https://github.com/civicrm/civicrm-core/commit/5d5302435d228938b65f9d021a8eb2147da96ef8
made the test pass - but by breaking it.
The test is designed to ensure that delayed recurring payment processors (ie. Paypal & Authorize.net) create a PENDING contribution when they are processed. Others (e.g IATS) set $params['contribution_status_id'] to Completed and they should result in a completed transaction. The purpose of the test is to ensure that IATS fixes don't break Paypal/ A.net by causing them to show as completed.
Superficially this test appears to have caught an instance where paypal has been broken.
The confounding factor is that in QA neither Dave or I saw this test fail. So we perhaps naively thought the failure was something environmental or something that would 'go away'.
However, the bug persisted after the merge and the most likely reason is that Paypal / A.net are broken.
Note that this commit MUST be reversed before this ticket can be closed
https://github.com/civicrm/civicrm-core/commit/5d5302435d228938b65f9d021a8eb2147da96ef8
Even if the test is removed it is a better outcome that keeping the test but completely breaking it by making the process both pay-later AND processed by a payment processor