Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-16533

clean up api syntax conformance tests

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: 4.6.3
    • Fix Version/s: None
    • Component/s: Test suite
    • Labels:
      None
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None

      Description

      The SyntaxConformanceTest.php tests test most of possible syntax problems with the api.
      However specific api tests also test some of those (or other) syntax checks. This causes those tests to be duplicates, and to be spread around the tests, which makes it difficult to see if there is full test coverage. Some things aren't tested and some things are tested multiple times.
      Quote: (10:59:35) eileen: I just found 6 instances of testDeleteEmptyParams
      That's perhaps to much.
      The plan is to check and list what SyntaxConformanceTest.php tests and what's missing, and to remove duplicate tests in the subclasses.
      I'll work on a structured approach in this issue.

        Attachments

          Activity

            People

            • Assignee:
              mallezie Tim Mallezie
              Reporter:
              mallezie Tim Mallezie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: