Details
-
Type:
Improvement
-
Status: Done/Fixed
-
Priority:
Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.7
-
Fix Version/s: 4.7
-
Component/s: None
-
Labels:None
-
Documentation Required?:None
-
Funding Source:Contributed Code
Description
Some functions that don't appear to be called :
CRM_Contribute_BAO_ContributionPage::composeMessage
(a couple more to add)
The functions CRM_Contribute_BAO_Contribution_Utils::formatAPIParams and CRM_Contribute_BAO_Contribution_Utils::processAPIContribution appear to have errors in them (based on IDE highlighting). Grepping these functions they are only called from bin/ContributionProcessor,
I believe the contributionprocessor class is unused / deprecated but am not suggesting it is removed. However, i have done a PR to move these functions to that class so they are directly tied to the only place that they are called from and are on the same deprecation path as that function