Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-16706

Merge CRM_Mailing_BAO_Mailing commonLetterCompose() and commonCompose() functions

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7
    • Fix Version/s: 4.7
    • Component/s: None
    • Labels:
      None

      Description

      The functions commonCompose() and commonLetterCompose() in CRM_Mailing_BAO_Mailing duplicate a lot of code.
      Those functions could probably better be merged.
      These functions are also responsible for adding tokens to message field. If we wan't to add tokens to some forms those need to be updated on both places, and added in 'different' 'hardcode' way depending on the used compose function.

        Attachments

          Activity

            People

            • Assignee:
              mallezie Tim Mallezie
              Reporter:
              mallezie Tim Mallezie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: