Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-17335

Stop passing CRM_Core_DAO::$_nullArray pointlessly

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.6.8
    • Fix Version/s: 4.7.9
    • Component/s: None
    • Labels:
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code

      Description

      Probably a bit of an ongoing on but it turns out that

      CRM_Core_DAO::$_nullArray

      is just a static var and it isn't always NULL!

      so a line like this

      CRM_Core_DAO::executeQuery($query, CRM_Core_DAO::$_nullArray);

      can potentially pick up parameters from the last time the static was used.

      Fortunately very few of the instances it is being used in still require it!

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: