Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-17516

Undefined variable in new report code

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7
    • Fix Version/s: 4.7
    • Component/s: None
    • Labels:
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code

      Description

      Hey

      My IDE is highlighting that $financialTypes is undefined in the following code added in a recent commit of yours. I have no idea the impact but assume there is some somewhere.

      Offending line is

      CRM_Financial_BAO_FinancialType::getAvailableFinancialTypes($financialTypes);

      /**

      • Generate temporary table to hold all contributions with permissioned FTs.
        *
      • @param object $query
      • @param string $alias
      • @param bool $return
        */
        public function getPermissionedFTQuery(&$query, $alias = NULL, $return = FALSE) {
        if (!CRM_Financial_BAO_FinancialType::isACLFinancialTypeStatus()) { return FALSE; }

        CRM_Financial_BAO_FinancialType::getAvailableFinancialTypes($financialTypes);
        if (empty($financialTypes))

        { $contFTs = "0"; $liFTs = implode(',', array_keys(CRM_Contribute_Pseudoconstant::financialType())); }

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: