CRM-17678 Adding cheque # creates additional transactions

There are more cases than I wanted where we ended up creating what are essentially bookkeeping transactions that cancel out each other's effects in QuickBooks in order to support other accounting packages. I don't recall that merely changing a cheque number was one of them, but it may have been. While wasteful in some ways, these transactions are harmless in others.

I would give a soft recommendation to not 'fix' this.

From my point of view this is in the category of being something I find confusing (and which makes it hard for me to validate that the entries created are correct when looking at the payments) rather than something someone is pushing to fix. It might become more topical once more people can see their payment data though

Actually Joe - do you want to try to find the spec for what changes a financial_trxn.

I feel like that table reflects the financial transactions against a contribution - generally the payments & administrative updates shouldn't result in extra rows.

I can't think of a case where that would be helpful for an accounting package (& I'm not sure which accounting packages you have given consideration to apart from Quickbooks.)

another oddity - this contribution had a financial type of campaign contribution. I changed the financial type to 'cash' (odd name for a type I know) & now all entries say cash...

And here is what you see if you change the type and refund.

I think it should have 2 rows at this stage - a refund for the type specified when refunding & a row for the original transaction

Also - it seems it's not possible to mark something as 'Pending refund' through the UI - although this would seem like a logical thing to do in practice.

I still hate this - but let's not keep it open without a consensus to change or anyone actively driving it