Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-17737

New Mailer dialog seems impossible to translate

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.6.10
    • Fix Version/s: 4.7.8
    • Labels:
      None
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code

      Description

      There seems to be no translation strings in Transifex for the new mailer design. Specifically, the strings in the lower "Preview" section are not available, so are "Draft" buttons.

      BTW. Is this the correct way to report all strings that can't be translated?

        Activity

        Hide
        johanv Johan Vervloet added a comment -

        Thank you so much for fixing this!

        Show
        johanv Johan Vervloet added a comment - Thank you so much for fixing this!
        Hide
        francescbassas Francesc Bassas i Bullich added a comment -

        Great news Mathieu! Thank you so much.

        One last thing, there is and easy way to recover the lost translated strings due to this issue?

        For example, before this issue, the "Unknown path" string was translated, see https://github.com/civicrm/l10n/commit/1d633232f3547eb5a2a0247b5eee60ea99d153da#diff-8cede461b214229f35fb2f0d9f970578L26269

        After your fix Mathieu, the string "Unknown path" appears again on Transifex but is unstranslated, see https://www.transifex.com/civicrm/civicrm/translate/#ca/common-base/83980048?q=Unknown%20path

        I see % of translations in https://www.transifex.com/civicrm/civicrm/ and it seems to have lost 10% of all the translations.

        Show
        francescbassas Francesc Bassas i Bullich added a comment - Great news Mathieu! Thank you so much. One last thing, there is and easy way to recover the lost translated strings due to this issue? For example, before this issue, the "Unknown path" string was translated, see https://github.com/civicrm/l10n/commit/1d633232f3547eb5a2a0247b5eee60ea99d153da#diff-8cede461b214229f35fb2f0d9f970578L26269 After your fix Mathieu, the string "Unknown path" appears again on Transifex but is unstranslated, see https://www.transifex.com/civicrm/civicrm/translate/#ca/common-base/83980048?q=Unknown%20path I see % of translations in https://www.transifex.com/civicrm/civicrm/ and it seems to have lost 10% of all the translations.
        Hide
        mlutfy Mathieu Lutfy added a comment -

        Transifex seems to have kept a record of it, since it shows up in the suggestions box, but we do not have a way to tell Transifex to apply all strings that have a 100% match to their suggestion.

        It might be possible to use "msgmerge" to merge the older and newer file (or maybe poedit has a feature for that, but I'm not sure), then to re-upload the meged file to Transifex. Only one component is affected ("mailing", common-components only had ~ 6 strings affected).

        The 10% drop on Transifex is because I also uploaded the 4.7 strings. Looking at untranslated strings in French, it has ~ 158 untranslated strings (it was at 100%, if I recall correctly). Using another metric [1], it gives me about 140-150 strings that had been lost.

        [1] git show 84234c17272c8e7f0d08b9652af81cd0604aa18b po/pot/mailing.pot | grep msgid | grep ^+ | wc -l

        Show
        mlutfy Mathieu Lutfy added a comment - Transifex seems to have kept a record of it, since it shows up in the suggestions box, but we do not have a way to tell Transifex to apply all strings that have a 100% match to their suggestion. It might be possible to use "msgmerge" to merge the older and newer file (or maybe poedit has a feature for that, but I'm not sure), then to re-upload the meged file to Transifex. Only one component is affected ("mailing", common-components only had ~ 6 strings affected). The 10% drop on Transifex is because I also uploaded the 4.7 strings. Looking at untranslated strings in French, it has ~ 158 untranslated strings (it was at 100%, if I recall correctly). Using another metric [1] , it gives me about 140-150 strings that had been lost. [1] git show 84234c17272c8e7f0d08b9652af81cd0604aa18b po/pot/mailing.pot | grep msgid | grep ^+ | wc -l
        Hide
        francescbassas Francesc Bassas i Bullich added a comment -

        Thanks Mathieu. You're right, I had not taken into account the chains of the 4.7 In such a case it does not seem so bad. I will try some of your directions to retrieve the lost strings. Thanks again!

        Show
        francescbassas Francesc Bassas i Bullich added a comment - Thanks Mathieu. You're right, I had not taken into account the chains of the 4.7 In such a case it does not seem so bad. I will try some of your directions to retrieve the lost strings. Thanks again!
        Hide
        klevie Kevin Levie added a comment -

        A slightly delayed reply...: Mathieu, thanks so much for pushing the new strings!
        I have sent an email to recent Dutch translation contributors to help with the >1250 new translations - we've got some work to do.

        (@mlutfy: I'll keep an eye on the civicrm-intl list from now on and start a discussion if future general l10n issues arise... and do email me if you can use some help keeping the translatable strings up to date)

        Show
        klevie Kevin Levie added a comment - A slightly delayed reply...: Mathieu, thanks so much for pushing the new strings! I have sent an email to recent Dutch translation contributors to help with the >1250 new translations - we've got some work to do. (@mlutfy: I'll keep an eye on the civicrm-intl list from now on and start a discussion if future general l10n issues arise... and do email me if you can use some help keeping the translatable strings up to date)

          People

          • Assignee:
            mlutfy Mathieu Lutfy
            Reporter:
            thoni56 Thomas Nilefalk
          • Votes:
            4 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development