Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-17785

Contribution edit form broken in popup for status cancelled/refunded

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.6, 4.7
    • Fix Version/s: 4.7.13
    • Component/s: CiviContribute
    • Labels:
    • Documentation Required?:
      None
    • Funding Source:
      Core Team Funds

      Description

      In the context of CRM-17589 I came across another bug with the contribution edit form:
      If the status is set to 'Refunded' or 'Cancelled' the cancellation information panel should be showing. If you click on the 'edit' link in a contact's contributions tab, the edit popup opens and it works. However if you do the same thing from a contribution search result, it does not work.

      I analysed the problem, and the reason is that the JS code adds a change handler to the #contribution_status_id element, which is usually working just fine. However, in the search form, there is another #contribution_status_id in the page than the one in the popup edit form: the one in the search parameters. Unfortunately the handler gets attached to that one, so the edit form logic doesn't work any more.

      I didn't look into this, but I could imagine that there is a more issues like this. What's the best way to restrict those selectors to the current popup context?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              b.systopia Björn Endres
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: