CRM-183 activity deletion inconsistency

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Component/s: None
    • Labels:
      None

      Description

      When we delete an open activity, we

      1a. get JavaScript confirmation
      2a. after confirming end up on a page with just the info that the activity was deleted and have to click again to go anywhere interesting.

      When we delete a closed activity (from Activity History), we

      1b. get HTML confirmation (i.e., another page has to load)
      2b. after confirming end up back on the activities page.

      I believe we should do 1a (falling back to 1b when there?s no JavaScript) and after confirming do 2b.

        Attachments

          Activity

          [CRM-183] activity deletion inconsistency
          Piotr Szotkowski added a comment -

          Hm, actually now it goes like this:

          If I delete from Activity History, I get the HTML confirmation and after deletion get returned to the search page. Should get the JavaScript confirmation (and only it if the JavaScript is enabled), and get returned to contact's Activity History.

          If I delete from Open Activities, I first get the JavaScript confirmation, then get the HTML confirmation, and then get returned to the search page. Should only get one confirmation (if JavaScript is enabled, then the JavaScript one, otherwise the HTML one) and get returned to contact's Open Activities.

          Kurund Jalmi added a comment -

          We made both Open Activity and Activity History consistent. (Javascript+HTML validation)
          If javascript is disabled, then only HTML validation is done.

          we follow the same pattern for administer pages (Tags, etc).

          Kurund Jalmi added a comment -

          Removed javascript confirmation for activity history and open activity.

          When deleted open activity/ activity history, shows the status message on the page where delete was triggered.

          Kurund Jalmi added a comment -

          on clicking delete, if javascript is enabled then we get confirmation box, else HTML confirmation

          Piotr Szotkowski added a comment -

          Tested, works.

            People

            • Assignee:
              Kurund Jalmi
              Reporter:
              Piotr Szotkowski

              Dates

              • Created:
                Updated:
                Resolved: