CRM-18323 Improved PCP Search and listing with DataTable

This is looking good. New Search listing seems to be much more interactive and easier to use. Thanks!

Few issues found on first cycle of QA -
1) "Disable" links doesn't seem to be working after the PR. It is ended with the API error message API (PCP, create) does not exist (join the API team and implement it!)
2) Success Notification of Approval is shown after page reload. To replicate -

• click on approve link of any of the PCP listed.
• Refresh the page (Success notification is shown on the container).

3) DataTable code seems to be using the legacy code(details on the PR).

Thanks for your comment

1) "Disable" links doesn't seem to be working after the PR. It is ended with the API error message API (PCP, create) does not exist (join the API team and implement it!)

Are you testing this PR with civirules extension? Then you have to exclude PCP as well in the pre hook.

If you want to test with civirules,
The following codes needs to be changed
in 'pre' function in CRM/Civirules/Utils/PreData.php
From – $nonPreEntities = array('GroupContact', 'EntityTag', 'ActionLog');
To – $nonPreEntities = array('GroupContact', 'EntityTag', 'ActionLog', 'PCP');

2) Success Notification of Approval is shown after page reload.

This is due to actions approve and reject call core method which has status msgs in it. I have to remove those. Thanks

Nope, I don't have CiviRules Extension installed on my setup. I've performed the QA on a fresh updated Civi + your PR.

i feel like this has a dependency on the pcp api

I'm going to close the PR https://github.com/civicrm/civicrm-core/pull/8045 because it needs work & has been sitting around for a while. It's kind of better to re-open a new PR once it has become active again as that moves it to the top of the PR list.