Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-190

Convertor.php Improvements (remove relative paths, dependencies...)

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 1.0, 1.1
    • Fix Version/s: 1.0, 1.1
    • Component/s: None
    • Labels:
      None

      Description

      K - below are Michal requirements and suggestions. If you feel there is a better way to meet his needs - please hook up w/ him and discuss...
      --------------------
      Sandboxes infrastructure uses distmaker script heavily for building
      tarballs, but also for generating PHP4 code. I just realised some of the
      problems users have with tarballs might come out of the fact, that
      bin/converter.php is out of synch with distmaker/utils/converter.php
      script. Can someone please do the following with bin/converter.sh
      script:
      a) fix the dependency on config file path:
      require_once "$homeDir/svn/crm/modules/config.inc.php";
      The path to svn root dir should be passed as a first parameter.
      b) fix relative path calls
      c) fix the hardcoded generated files target dir path (s/b also a
      parameter)

      The goal would be to call the converter script from anywhere (like
      "php ../../bin/converter.php PATH1 PATH2") and it still did it's work
      properly. After those fixes are introduced, let's move converter.php to
      distmaker's directory to keep only one version of the file.

        Attachments

          Activity

            People

            • Assignee:
              kurund Kurund Jalmi
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: