CRM-19149 Financial Transactions Created When Editing a Negative Contribution Incorrect

          Details

          • Documentation Required?:
            None
          • Funding Source:
            Contributed Code

            Description

            Hi guys,

            This issue was reproduced in demo environment - the scenario: negative contributions mistakenly imported with a payment instrument of "Check" were then modified to reflect a payment instrument of "Credit Card" that resulted in positive credit card transactions instead of negative.

            To reproduce:

            1. Create a negative contribution leaving the default payment method of "Check"
            2. Edit the contribution to change the payment method to "Credit Card"
            3. Create a new accounting batch and search for the contributions - the financial transaction created for credit card is positive instead of negative (see attached screen shot for visual reference).

            Thanks in advance for your time in looking into this,
            Tamar

              Attachments

                Activity

                [CRM-19149] Financial Transactions Created When Editing a Negative Contribution Incorrect
                Wahyu Kodar added a comment - - edited

                Fixed at https://github.com/civicrm/civicrm-core/pull/8982

                Seamus Lee added a comment -

                Tamar Meir Tamar are you in a position to test out https://github.com/civicrm/civicrm-core/pull/8982 or maybe KarinG Karin are you able to test the patch?

                Seamus

                KarinG added a comment -

                Thanks Seamus Lee - Tamar Meir - putting this in QA and assigning this to you - hopefully this will fix this issue you reports. Please do let us know.

                Tamar Meir added a comment -

                Looks like https://github.com/civicrm/civicrm-core/pull/8982 build failed so can't test - assigning back to Karin b/c it doesn't seem like I have permissions to assign back to Wahyu for further fixing - once there is a successful build, please assign back to me and I will test ASAP.

                Thanks all for your time!

                Seamus Lee added a comment -

                Tamar Meir Tests have passed have assigned back to you

                Tamar Meir added a comment -

                Seamus Lee Tested - looks like things are almost there - detailed comments and screen shots of test results on https://github.com/civicrm/civicrm-core/pull/8982

                Assigning back to you....

                Seamus Lee added a comment -

                Tamar Meir Hi Tamar

                assigning back to you, i think we have fixed the issues found in your test

                Seamus

                Tamar Meir added a comment -

                Hi again guys - sorry for the delayed response - just checked and we are nearly there - posted comments to PR: https://github.com/civicrm/civicrm-core/pull/8982

                Thanks as always!

                Tamar Meir added a comment -

                Houston, we have lift off! Comments in PR.

                Thanks for your rapid turn around on this!

                Yashodha Chaku added a comment -

                PR https://github.com/civicrm/civicrm-core/pull/8982 has been merged.

                  People

                  • Assignee:
                    Seamus Lee
                    Reporter:
                    Tamar Meir

                    Dates

                    • Created:
                      Updated:
                      Resolved: