Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-19278

Google Geocoding - Errors are ignored

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Minor
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.6, 4.7
          • Fix Version/s: 4.7.14
          • Component/s: None
          • Labels:
          • Documentation Required?:
            None
          • Funding Source:
            Contributed Code

            Description

            When a Geocoding request is made, and a return status other than OK, or OVER_QUERY_LIMIT is returned the current implementation treats it as "ZERO_RESULTS". The request code should support the full range of return status codes.

            https://developers.google.com/maps/documentation/geocoding/intro#StatusCodes

            As OK, and ZERO_RESULTS are the only two non-error messages I suggest the logic flow check for those, and handle them accordingly, and if it is anything else log it as an error.

            I'm including a patch.

              Attachments

                Activity

                  People

                  • Assignee:
                    monish.deb Monish Deb
                    Reporter:
                    tobiaslounsbury Tobias Lounsbury
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: