Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-19389

Fatal Error in Forms (4.7.12 Regression)

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Blocker
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.12
    • Fix Version/s: 4.7.12
    • Component/s: None
    • Documentation Required?:
      None
    • Funding Source:
      Core Team Funds

      Description

      There is Fatal Error in setting pages and Form whichever extend CRM_Core_Form with changed
      access level for $_action. Like in

      http://dmaster.demo.civicrm.org/civicrm/admin/setting/preferences/contribute?reset=1
      PHP Fatal error: Access level to CRM_Admin_Form_Preferences::$_action must be public (as in class CRM_Core_Form) in <module directory>/civicrm/CRM/Admin/Form/Preferences.php on line 37

      I think these files were missed on https://github.com/civicrm/civicrm-core/pull/9039

      Monishs-MacBook-Pro:civicrm monish$ grep -irn "protected \$_action" CRM/
      CRM//Activity/Selector/Search.php:120: protected $_action;
      CRM//Admin/Form/Preferences.php:40: protected $_action = NULL;
      CRM//Campaign/Form/Campaign.php:44: protected $_action;
      CRM//Campaign/Form/Survey.php:51: protected $_action;
      CRM//Campaign/Form/SurveyType.php:59: protected $_action;
      CRM//Campaign/Selector/Search.php:110: protected $_action;
      CRM//Case/Selector/Search.php:106: protected $_action;
      CRM//Contact/Page/View.php:58: protected $_action;
      CRM//Contact/Selector/Custom.php:82: protected $_action;
      CRM//Contact/Selector.php:115: protected $_action;
      CRM//Contribute/Selector/Search.php:128: protected $_action;
      CRM//Core/Form/Search.php:52: protected $_actionButtonName;
      CRM//Core/Page/Basic.php:35: protected $_action;
      CRM//Core/Selector/Controller.php:108: protected $_action;
      CRM//Core/StateMachine.php:75: protected $_action = NULL;
      CRM//Event/Form/ManageEvent.php:59: protected $_action;
      CRM//Event/Form/SelfSvcTransfer.php:106: protected $_action;
      CRM//Event/Form/SelfSvcUpdate.php:91: protected $_action;
      CRM//Event/Selector/Search.php:126: protected $_action;
      CRM//Grant/Selector/Search.php:113: protected $_action;
      CRM//Mailing/Page/Browse.php:60: protected $_action;
      CRM//Mailing/Selector/Search.php:113: protected $_action;
      CRM//Member/Selector/Search.php:110: protected $_action;
      CRM//Pledge/Selector/Search.php:114: protected $_action;

      Will send a PR with desired change in access modifier protected-to-public

        Attachments

          Activity

            People

            • Assignee:
              monish.deb Monish Deb
              Reporter:
              monish.deb Monish Deb
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: