CRM-19678 No Membership Renewal Activity is created when a Pay Later is set to Completed

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Minor
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.6.14, 4.7.13
          • Fix Version/s: 4.7.20
          • Component/s: CiviMember
          • Labels:
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            None
          • Funding Source:
            Core Team Funds
          • Verified?:
            No

            Description

            If a Memberships is purchased online using Pay Later, then when the payment is set to Completed a Membership Renewal Activity should be created for consistency. Benefit is that this means searches for that Activity Type provide useful data in terms of tracking renewals.

              Attachments

              1. new-membership-paylater.png
                131 kB
                Monish Deb
              2. new-membership-payment.png
                145 kB
                Monish Deb
              3. renewal-paylater.png
                195 kB
                Monish Deb
              4. renewal-payment.png
                200 kB
                Monish Deb

                Activity

                [CRM-19678] No Membership Renewal Activity is created when a Pay Later is set to Completed
                Monish Deb added a comment -

                Peter Davis can you test my patch https://github.com/civicrm/civicrm-core/pull/9447 ?

                Monish Deb added a comment - - edited

                Peter Davis Eileen McNaughton I have updated the PR https://github.com/civicrm/civicrm-core/pull/9468 and as per the patch these are the use-cases:

                1. If a pay-later is chosen for New membership then after registration it will create Scheduled Membership Signup activity
                Screenshot - new-membership-paylater.png

                2. After successful payment of new membership created after registration or CC payment done for the pending contribution created at step 1, 3 activities are created which are - new-membership-payment.png
                (As you can see any scheduled membership signup added in step 1 will be updated to Completed)

                3. If a pay-later is chosen for Membership Renewal then after registration it will create Scheduled Membership Renewal activity . Screenshot - renewal-paylater.png

                4. After successful payment of membership renewal done after registration or CC payment done for the pending contribution created at step 3, 3 activities are created which are - renewal-payment.png
                (As you can see any scheduled membership renewal added in step 3 will be updated to Completed)

                Monish Deb added a comment -

                In addition added unit test, did some improvement and optimization to the existing code.

                Peter Davis added a comment -

                Looks good to me, can't see anything obviously incorrect or perplexing.

                Peter Davis added a comment -

                just checking if this was committed for 4.7.15 or not. I see the related ticket #19600 was fixed

                Peter Davis added a comment -

                Pls reference this spreadsheet where we are trying to provide a clear collation of tests that result in bad outcomes.

                https://docs.google.com/spreadsheets/d/1UPfA10UIKjuOnTqyradi6vfOhveUts161PpSm_sb5f0/edit#gid=0

                Monish Deb added a comment -

                Closing this issue now as PR https://github.com/civicrm/civicrm-core/pull/10324 is reviewed and merged.

                  People

                  • Assignee:
                    Monish Deb
                    Reporter:
                    Peter Davis

                    Dates

                    • Created:
                      Updated:
                      Resolved: