Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-19844

Inbound activity emails - don't fire hook if activity processing failed

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.6.24
    • Fix Version/s: 4.7.16
    • Component/s: None
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      Developer Doc
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      In CRM_Utils_Mail_EmailProcessor there is code to process emails as activities.

      In event that the Activity processing fails, we should not then fire

                  CRM_Utils_Hook::emailProcessor('activity', $params, $mail, $result);
      

      If an email is inbound which triggers Activity API to reject it (eg, Google Drive "Share document" link which contains a <script> tag), then this may prevent processing of further emails.

      Trivial fix is to move the hook call inside the block which ensures that the Activity,create API call was successful.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              xurizaemon Chris Burgess
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: