Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-19882

CRM_Core_BAO_Setting::validateSettingsInput() should not throw an exception

          Details

          • Type: Bug
          • Status: Open
          • Priority: Trivial
          • Resolution: Unresolved
          • Affects Version/s: 4.7.15
          • Fix Version/s: None
          • Component/s: None
          • Labels:
            None
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            None
          • Funding Source:
            Needs Funding
          • Verified?:
            No

            Description

            When the Setting API gets a parameter it doesn't like, it throws an exception. (I have only seen this with the create method, but I haven't been looking very hard.)

            I argue this is bad for the following reasons:

            • It's inconsistent with the other APIs, which I believe simply ignore extraneous params.
            • It results in (or at least relates to) errors which are tricky to track down (CRM-18207, CRM-18347, CRM-19877)
            • It is incompatible with at least one Joomla caching plugin
            • It forces us to maintain (or sort of maintain) a blacklist of params which shouldn't trigger the error.

              Attachments

                Issue Links

                is supplemented by

                Bug - A problem which impairs or prevents the functions of the product. CRM-18207 Settings values not showing up.

                • Major - Major loss of function.
                • Done/Fixed

                Bug - A problem which impairs or prevents the functions of the product. CRM-19877 on Joomla api.Setting.create fails with "option,task not valid settings"

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • Done/Fixed

                Bug - A problem which impairs or prevents the functions of the product. CRM-18347 error message after clearing security release message

                • Trivial - Cosmetic problem like misspelt words or misaligned text.
                • Done/Fixed

                  Activity

                    People

                    • Assignee:
                      timotten Tim Otten
                      Reporter:
                      pittstains Frank J. Gómez
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated: