CRM-19918 Price field "Active on" date ignored in Edit Event Registration > "Change Selections"

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.15, 4.7.16
    • Fix Version/s: 4.7.17
    • Component/s: None
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Core Team Funds
    • Verified?:
      No

      Description

      Steps to reproduce:

      1. Ensure there's an event that's using a price set.
      2. Configure one price field in the price set to have a future date in the "Active On" setting.
      3. Find a contact who is not registered for this event. Open the contact's record and click "Add Event Registration", then save the new registration. Observe during this process that the price field from step 2 (above) is not displayed in the price options for this registration; this is correct behavior.
      4. For this contact, under the Events tab, find the registration for this event, and click the "Edit" link for this event registration. Under "Selections" find and click the "Change Selections" link; this opens the "Change Registration Selections" form. On this form, observe that the price field from step 2 is displayed; this is incorrect behavior, because the price field is configured to be inactive until the given future date.

      Extra trouble:
      If the price field in question is configured Required=yes, there's no effective way to change selections for any participant in this event, because the "Change Registration Selections" form will require that this price field be selected, even though nobody should be able to select this field until the given future date.

        Attachments

          Activity

          [CRM-19918] Price field "Active on" date ignored in Edit Event Registration > "Change Selections"
          Monish Deb added a comment -

          This behaviour was changed due to https://issues.civicrm.org/jira/browse/CRM-16456 where expired price fields were also included in 'Change fee selection' by setting ```getAllPriceField = FALSE``` at https://github.com/civicrm/civicrm-core/pull/5832/files#diff-22f5b9b128f6f47783a34b92045bcd2cR682 . But this also include the future price fields along with expired ones.

          I have submitted the PR https://github.com/civicrm/civicrm-core/pull/9764, making it mandatory to remove future price fields in both 'Event Registration' and 'Change Fee Selection' forms.

          Allen Shaw added a comment -

          Thanks for working on this, Monish. I'm adding the `Regression` label to help with learning more about regressions.

          Jitendra Purohit added a comment -

          PR has been merged.

            People

            • Assignee:
              Jitendra Purohit
              Reporter:
              Allen Shaw

              Dates

              • Created:
                Updated:
                Resolved: