Details
-
Type:
Improvement
-
Status: Open
-
Priority:
Trivial
-
Resolution: Unresolved
-
Affects Version/s: 4.7
-
Fix Version/s: None
-
Component/s: Core CiviCRM
-
Labels:None
-
Versioning Impact:Patch (backwards-compatible bug fixes)
-
Documentation Required?:None
-
Funding Source:Contributed Code
-
Verified?:No
Description
In CRM-19934 I propose a huge performance fix with a couple of refactors in CiviCRM Core. As the proposed solution is a huge fix I have decided to break it down in smaller chunks. This is one of those smaller chunks.
The improvement proposed in this issue is to move the function buildACLClause from each custom search class to CRM_Contact_Form_Search_Custom_Base class so that each derived class could use the generic buildACL function or override the function if needed.
This will also make this comply with the report classes where buildACLClause function is defined in CRM_Report_Form class.