Details
-
Type: Bug
-
Status: Done/Fixed
-
Priority: Minor
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.7.16
-
Fix Version/s: 4.7.19
-
Component/s: None
-
Labels:None
-
Versioning Impact:Patch (backwards-compatible bug fixes)
-
Documentation Required?:None
-
Funding Source:Contributed Code
-
Verified?:No
Description
We do a 'best effort' create line-item
try {
// @todo this should be done by virtue of editing the line item as this link // is deprecated. This may be the case but needs testing. civicrm_api3('membership_payment', 'create', array(
'membership_id' => $value['entity_id'],
'contribution_id' => $contribution->id,
));
}
catch (CiviCRM_API3_Exception $e) {
// we are catching & ignoring errors as an extra precaution since lost IPNs may be more serious that lost membership_payment data // this fn is unit-tested so risk of changes elsewhere breaking it are otherwise mitigated
{color}}
The above will roll back on fail, adding
is_transactional= false
will prevent that. We know from the comments that we want to ignore fails here